ci: test minimal version of dependencies #493
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `cargo minimal-versions` to check whether the minimal specified versions dependencies successfully compiles. As this repo has no `Cargo.lock`, CI will always test with the newest compatible dependency versions. This new job will check oldest compatible dependency version as well. This requires unstable nightly feature `minimal-versions`, but they abstracted away by `cargo-minimal-versions` project.
caspermeijn
force-pushed
the
minimal_versions
branch
from
5e201cb to
fad2883
Compare
Member
|
Are you able to see the CI output to iterate on this? |
Contributor
Author
So I have been a bit dumb and just committed this CI job without testing. I will look into what dependencies need to change to make this work and add them as separate commits in this PR. |
Contributor
Author
|
I have not been able to make this work. Some of the transient dependencies have wrong minimal dependencies. I have found a few crates where the minimal dependencies have been fixed in the latest version, but that doesn't help because we want to support the older version. My conclusion is: a CI job for minimal version is not feasible as long as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
cargo minimal-versionsto check whether the minimal specified versions dependencies successfully compiles.As this repo has no
Cargo.lock, CI will always test with the newest compatible dependency versions. This new job will check oldest compatible dependency version as well.This requires unstable nightly feature
minimal-versions, but they abstracted away bycargo-minimal-versionsproject.prostuses the same job for several months: https://github.com/tokio-rs/prost/blob/21208abf667313866f79d3d1438310c4dc20bdff/.github/workflows/ci.yml#L168-L176