Skip to content

Conversation

@MoonBoi9001
Copy link
Member

@MoonBoi9001 MoonBoi9001 commented Nov 21, 2025

Summary

Adds support for inline JSON credentials while maintaining official Google Cloud API usage.

Problem

The auth refactor (PR #42) removed inline credential support.

Solution

New function: prepare_credentials_for_adc()

  • Detects credential format (inline JSON vs file path)
  • For inline JSON: writes to /tmp/gcp-credentials.json with 0o600 permissions, updates env var
  • For file paths: validates existence (backward compatible)
  • Clears sensitive data from memory after use

Release: Minor bump (0.4.2 → 0.4.3)

@MoonBoi9001 MoonBoi9001 marked this pull request as draft November 21, 2025 04:35
@MoonBoi9001 MoonBoi9001 marked this pull request as ready for review November 21, 2025 04:38
@MoonBoi9001
Copy link
Member Author

Also fixed: Leak of sensitive data to slack channel via webhook notification caused by error messages being too broad and catching the full error message

@MoonBoi9001 MoonBoi9001 merged commit b1d99e6 into main Nov 21, 2025
12 checks passed
@MoonBoi9001 MoonBoi9001 deleted the adc-inline-credentials branch November 21, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants