perf: optimize allocation rules evaluation from O(n²) to O(n) #1147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madumas
force-pushed
the
perf/optimize-allocation-rules
branch
from
72bfa9b to
b87eeb2
Compare
Replace repeated Array.filter() + Array.find() with Map-based lookup for deployment rules. - Add preprocessRules() function to create Map for O(1) rule lookups - Update isDeploymentWorthAllocatingTowards() to use pre-processed rules Map - Update evaluateDeployments() to preprocess rules once instead of per deployment - Update AllocationManager.matchingRuleExists() to use optimized lookup Performance improvement: - Before: O(n²) - filter + find for each deployment evaluation - After: O(n) - single preprocessing + O(1) lookups per deployment - Significant speedup when evaluating many deployments against many rules Fixes performance bottleneck in allocation rule evaluation where processing thousands of deployments with hundreds of rules resulted in quadratic complexity.
madumas
force-pushed
the
perf/optimize-allocation-rules
branch
from
b87eeb2 to
2618f23
Compare
dwerner
added a commit
that referenced
this pull request
Dec 5, 2025
Replace repeated Array.filter() and Array.find() operations with a Map-based lookup system for deployment rules. Changes: - Add preprocessRules() function to create a Map for O(1) rule lookups - Update isDeploymentWorthAllocatingTowards() to use preprocessed rules - Update evaluateDeployments() to preprocess rules once before iteration - Update matchingRuleExists() in AllocationManager to use optimized lookup This eliminates quadratic complexity when evaluating thousands of deployments against hundreds of rules. Based on: #1147 Original author: madumas Original commit: 2618f23
Contributor
|
pulled in #1149 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace repeated Array.filter() + Array.find() with Map-based lookup for deployment rules.
Performance improvement:
Fixes performance bottleneck in allocation rule evaluation where processing thousands of deployments with hundreds of rules resulted in quadratic complexity.