Skip to content

Return error from subscribe and unsubscribe methods #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itsmylife merged 3 commits into from
Nov 10, 2025
Merged

Return error from subscribe and unsubscribe methods #157

itsmylife merged 3 commits into from
Nov 10, 2025

Conversation

@itsmylife
Copy link
Contributor

@itsmylife itsmylife commented Nov 7, 2025

We want to mark the errors as downstream coming from subscribe and unsubscribe methods.

@itsmylife itsmylife requested a review from zoltanbedi as a code owner November 7, 2025 21:03
zoltanbedi
zoltanbedi approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmylife itsmylife requested a review from a team as a code owner November 10, 2025 10:41
@itsmylife itsmylife merged commit 266b48d into main Nov 10, 2025
18 checks passed
@itsmylife itsmylife deleted the ismail/update-error-sources branch November 10, 2025 10:52
@github-project-automation github-project-automation bot moved this to Complete in OSS Big Tent Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

OSS Big Tent
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@itsmylife @zoltanbedi