-
Notifications
You must be signed in to change notification settings - Fork 139
Pagination cursor initial value has next page #1201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pagination cursor initial value has next page #1201
Conversation
|
Hiya. Sorry for the delay reviewing this. Thank you for the valuable contibution. We are looking into this. Note: We are looking for a generic stop condition implementation that works for all the pagination types. So the review may take bit longer. |
So when the generic implementation can be expected? I know this is in beta, but it is really handy to have this work properly. |
|
I would love this feature! |
@yesoreyeram any update on this? I'm running into a cursor issue that is solved by this PR. |
The current implementation lacks full support for cursor pagination in QueryQL (GraphQL). Issues include the inability to set an initial cursor value for the first query, broken logic preventing cursor field replacement, and flawed exit criteria that ignore the "has next page" condition, potentially causing infinite loops by only checking if the cursor is an empty string.
Pagination Cursor for QueryQL:
The GraphQL cursor pagination documentation:
https://graphql.org/learn/pagination/#pagination-and-edges