use bun glob & update compressible extensions #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
added some more tiny changes :D |
gornostay25
requested changes
Oct 2, 2024
Owner
gornostay25
left a comment
gornostay25
left a comment
There was a problem hiding this comment.
Looks good, but some minor issues
| * @param {'gz' | 'br'} format | ||
| */ | ||
| async function compress_file(file, format = "gz") { | ||
| /*** @param {string} file* @param {'gz' | 'br'} format*/ async function compress_file( |
Owner
There was a problem hiding this comment.
Looks good but there are some formatting issues
Author
There was a problem hiding this comment.
Looks good but there are some formatting issues
i ran bun format before every commit
| * @param {string} out | ||
| */ | ||
| function patchServerWebsocketHandler(out) { | ||
| /*** @param {string} out*/ function patchServerWebsocketHandler(out) { |
| * @param {import('.').CompressOptions} options | ||
| */ | ||
| async function compress(directory, options) { | ||
| /*** @param {string} directory* @param {import('.').CompressOptions} options*/ async function compress( |
|
|
||
| /** @type {import('.').default} */ | ||
| export default function (opts = {}) { | ||
| /** @type {import('.').default} */ export default function (opts = {}) { |
|
|
||
| /** | ||
| * @default html,js,json,css,svg,xml,wasm | ||
| */ |
Owner
There was a problem hiding this comment.
Why you removed this comment?
Author
There was a problem hiding this comment.
Why you removed this comment?
because its way more than those anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds 2 changes: