Skip to content

Conversation

@jpoehnelt
Copy link
Member

No description provided.

…e JSDoc type checking for `.gs` files via TSC
@jpoehnelt jpoehnelt requested a review from a team as a code owner November 21, 2025 20:04
@jpoehnelt jpoehnelt requested a review from sqrrrl November 21, 2025 20:04
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jpoehnelt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces significant improvements to the project's development workflow and code quality. It modernizes the package management system by adopting pnpm, provides a detailed guide for Apps Script development, and integrates static type checking for Apps Script files using JSDoc and TypeScript. These changes aim to make development more efficient, consistent, and less prone to errors.

Highlights

  • Package Manager Migration: The project has migrated from npm/yarn to pnpm, streamlining dependency management and potentially improving performance and disk space usage.
  • Apps Script Development Guide: A new comprehensive guide (GEMINI.md) has been added, detailing best practices for developing Google Apps Script projects, including modern JavaScript features and Apps Script V8 runtime specifics.
  • JSDoc Type Checking for .gs files: JSDoc-based type checking has been enabled for .gs (Google Apps Script) files using TypeScript, enhancing code quality and maintainability by catching type errors early.
Ignored Files
  • Ignored by pattern: .gemini/** (1)
    • .gemini/settings.json
  • Ignored by pattern: .github/workflows/** (3)
    • .github/workflows/lint.yml
    • .github/workflows/publish.yaml
    • .github/workflows/test.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces pnpm for package management and a new TypeScript-based script for type-checking .gs files using JSDoc, which is a great step towards improving code quality and developer experience. The PR also includes comprehensive documentation for Apps Script development and the new type-checking process.

My review focuses on the new check-gs.ts script. I've found a couple of critical bugs in the file copying and error path rewriting logic that will prevent the script from working as intended. I've also pointed out a type-safety issue in the error handling. Addressing these points will ensure the new type-checking tool is robust and reliable.

@jpoehnelt jpoehnelt changed the title feat: Introduce pnpm, add an Apps Script development guide, and enable JSDoc type checking for .gs files via TSC build: pnpm and enable JSDoc type checking for .gs files via TSC Nov 21, 2025
@jpoehnelt jpoehnelt merged commit 3ebacfe into main Nov 21, 2025
10 of 36 checks passed
@jpoehnelt jpoehnelt deleted the build/check-tsc branch November 21, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant