Skip to content

Update variables for non-nullability in latest pkg:pubspec_parse #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Update variables for non-nullability in latest pkg:pubspec_parse #500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mono_repo/lib/src/ci_shared.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Map<String, List<CIJobEntry>> groupCIJobEntries(List<CIJobEntry> jobEntries) =>

void validateRootConfig(RootConfig rootConfig) {
for (var config in rootConfig) {
final sdkConstraint = config.pubspec.environment?['sdk'];
final sdkConstraint = config.pubspec.environment['sdk'];

if (sdkConstraint == null) {
continue;
Expand Down
4 changes: 2 additions & 2 deletions mono_repo/lib/src/utilities.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ void handlePubspecInSdkList(
return;
}

final sdkConstraint = pubspec.environment?['sdk'];
final sdkConstraint = pubspec.environment['sdk'];

Version? lowerVersion;
if (sdkConstraint is VersionRange && sdkConstraint.includeMin) {
Expand Down Expand Up @@ -142,7 +142,7 @@ extension PubspecExtension on Pubspec {
? '[![pub package](https://img.shields.io/pub/v/$name.svg)](https://pub.dev/packages/$name)'
: '';

bool get _dependsOnFlutterSdk => environment?.containsKey('flutter') ?? false;
bool get _dependsOnFlutterSdk => environment.containsKey('flutter');

bool get _dependsOnFlutterPackage => _dependsOnPackage('flutter');

Expand Down
2 changes: 1 addition & 1 deletion mono_repo/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies:
meta: ^1.0.0
path: ^1.4.1
pub_semver: ^2.0.0
pubspec_parse: ^1.0.0
pubspec_parse: ^1.4.0
yaml: ^3.0.0

dev_dependencies:
Expand Down
Loading