Skip to content

Allow @JsonKey to be used on constructor parameters #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 7, 2025
Merged

Allow @JsonKey to be used on constructor parameters #1505

merged 20 commits into from
Aug 7, 2025

Conversation

@huanghui1998hhh
Copy link
Contributor

@huanghui1998hhh huanghui1998hhh commented Jul 1, 2025 •
edited
Loading

About #1437

Allow @JsonKey to be used on constructor parameters, where the @JsonKey properties will override the corresponding field properties.

@huanghui1998hhh
Copy link
Contributor Author

huanghui1998hhh commented Jul 1, 2025

I noticed that the current master branch has WIP commits, so I didn't update the CHANGELOG.md.

@huanghui1998hhh
Copy link
Contributor Author

huanghui1998hhh commented Jul 2, 2025

@kevmoo Request for review

@huanghui1998hhh
Copy link
Contributor Author

huanghui1998hhh commented Jul 3, 2025

@kevmoo I can run workflow successfully in my forked repo.
https://github.com/huanghui1998hhh/json_serializable.dart.official/actions/runs/16040656161
Please take a look.

kevmoo
kevmoo reviewed Jul 17, 2025
View reviewed changes
@huanghui1998hhh huanghui1998hhh requested a review from kevmoo July 18, 2025 02:42
@kevmoo
Copy link
Collaborator

kevmoo commented Jul 24, 2025

failing tests?

kevmoo
kevmoo reviewed Jul 24, 2025
View reviewed changes
Copy link
Collaborator

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need changelog entries for both packages, too.

@huanghui1998hhh
Copy link
Contributor Author

huanghui1998hhh commented Jul 24, 2025

@kevmoo
There are some additional warnings that cause the test to fail

W SDK language version 3.10.0 is newer than analyzer language version 3.9.0. Run dart pub upgrade.

This dosen't seems to be caused by my commit. Should I modify annotation_version_test?

@huanghui1998hhh huanghui1998hhh requested a review from kevmoo July 24, 2025 07:53
kevmoo
kevmoo reviewed Jul 24, 2025
View reviewed changes
huanghui1998hhh and others added 3 commits July 25, 2025 10:14
@huanghui1998hhh
Copy link
Contributor Author

huanghui1998hhh commented Jul 26, 2025

@kevmoo There are some additional warnings that cause the test to fail

W SDK language version 3.10.0 is newer than analyzer language version 3.9.0. Run dart pub upgrade.

This dosen't seems to be caused by my commit. Should I modify annotation_version_test?

@kevmoo I need some help. We need to bump analyzer to 8.0.0 to pass the tests, but there are many version conflicts. Many packages have not yet adapted to analyzer 8.0.0.

@huanghui1998hhh huanghui1998hhh requested a review from kevmoo August 1, 2025 05:45
@huanghui1998hhh
Copy link
Contributor Author

huanghui1998hhh commented Aug 7, 2025

@kevmoo Plz take a look when you have a moment.

kevmoo
kevmoo approved these changes Aug 7, 2025
View reviewed changes
json_annotation/CHANGELOG.md
@@ -1,6 +1,7 @@
## 4.9.1-wip
Copy link
Collaborator

@kevmoo kevmoo Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do the follow-up here. We should bump this to 4.10 since we're adding a feature.

@kevmoo kevmoo merged commit 4298f97 into google:master Aug 7, 2025
18 checks passed
@kevmoo kevmoo mentioned this pull request Aug 7, 2025
Closed
@NonymousMorlock
Copy link

NonymousMorlock commented Aug 15, 2025

When will this go live on the pub?

vkorencik pushed a commit to TypeSoft-Ltd/json_serializable.dart that referenced this pull request Sep 11, 2025
@huanghui1998hhh @vkorencik
Allow @JsonKey to be used on constructor parameters (google#1505)
ed4deb1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmoo kevmoo kevmoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huanghui1998hhh @kevmoo @NonymousMorlock