-
Notifications
You must be signed in to change notification settings - Fork 0
element: ak-progress #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kensternberg-authentik
wants to merge
7
commits into
main
Choose a base branch
from
element/ak-progress
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* element/ak-icon: Prettier has opinions. Added some docs. Prettier has opinions. Prettier's opinions sometimes suck. Prettier still has opinions. Added types to make Teffen happy. rem, not em, for the pseudo-patternfly icon sizes derivef from fontawesome. Otherwise, the multiplicative effect is... dramatic. Icons as big as your monitor. Removing unneeded references. Added FontAwesome icon sizes to repetoire. Also: Prettier has opinions. # ak-icon Icon maybe final Initial check-in for icons. Still needs testing. .
* main: (41 commits) Forgot to run , and now that I have a hook to do it for me, this is making it whiny. Fixed typo in css. Added comments to the wcc file. This commit revises the WCCSS transpiler, using the regular expression and merge algorithms recommended by the Patternfly 5 React team. Added wccss pass to package.json. Type inference FTW. Needed to put tools build in-line This commit ports the Elements' build tools to Typescript Cleanup. New css build completing. Crawling back to the original starting point, but this time with better tooling. Save point. This commit introduces a dark-mode controller and code. A working dark mode, although with some dubious decisions Build system revised into a more unixy pattern: each script does one thing well. Bump validator from 13.15.15 to 13.15.20 (#10) Bump vite (#9) First stab at the dark-mode controller; it takes orders from the central context, if there is one, but if not, it tries to determine the mode itself by looking at the user's preferences. Revised brand to meet a... more modern standard. npm trusted publisher ...
Merge had to be hand-repaired as it failed to build after merge. The linting on `main` was more stringent than what this had had before application. * main: (41 commits) Added comment explaining why the initial `attachToAnchor` is run in a late animation frame after `connectedCallback()` admin: adjustments found during integration Removed default border on dialog for tooltip. We'll manage that ourselves, using Patternfly's layout. Continuing to adjust for dark mode, with additions for pulling fonts past the shadowDOM. re-arrange the CSS to better support dark mode. Merge mangling. Something got lost in the merge. Update .gitignore Adopted many of the suggestions from @GirlBossRush Handling focus grabbing. Update src/ak-tooltip/ak-tooltip.component.ts Update src/ak-tooltip/ak-tooltip.component.ts Update src/ak-tooltip/ak-tooltip-state-machine.ts Not sure how that all got re-arranged like that. elements: lintpicking Added types to the state machine. element: ak-tooltip Bump glob (#36) Bump js-yaml from 3.14.1 to 3.14.2 (#33) Bump validator from 13.15.15 to 13.15.23 (#40) ...
# What This commit adapts the P5 Progress Bar to the Authentik design; encapsulated, with an `XS` and `indeterminate` progress variant. It has a custom dark mode and some other minor customizations. To that end, the wcc file has been overriden.
✅ Deploy Preview for authentik-elements-storybook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elements/progress-bar:
What
This commit adapts the P5 Progress Bar to the Authentik design; encapsulated, with an
XSandindeterminateprogress variant.It has a custom dark mode and some other minor customizations. To that end, the wcc file has been overriden.