Skip to content

Fix off-by-one error in lint-go-gopls.sh #36027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix off-by-one error in lint-go-gopls.sh #36027

wants to merge 1 commit into from

Conversation

@silverwind
Copy link
Member

@silverwind silverwind commented Nov 25, 2025

The error count was off by one because echo -n '' | wc -l and echo -n 'xxx' | wc -l both return 0. Now it special-cases the empty string so it counts as 0.

@silverwind
Fix off-by-one error in lint-go-gopls.sh
946e3fa 
The error count was off by one because `echo -n '' | wc -l` and `echo -n 'xxx' | wc -l` both return 0.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 25, 2025
@silverwind
Copy link
Member Author

silverwind commented Nov 25, 2025 •
edited
Loading

Actually I think we can remove lint-go-gopls because some (but not all) analyzers in use are available in golangci-lint as part of the govet linter, making this script also obsolete. I will do that in another PR.

@silverwind silverwind closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@silverwind @GiteaBot