Skip to content

Fix incorrect viewed files counter if file has changed #36009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −10
Open

Fix incorrect viewed files counter if file has changed #36009

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4224515
Fix incorrect viewed files counter if file has changed
bytedream Nov 23, 2025
215620e
Make linter happy
bytedream Nov 23, 2025
8a3ff4b
Use alternative method to save modified changed files state
bytedream Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions services/gitdiff/gitdiff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"html"
"html/template"
"io"
"maps"
"net/url"
"path"
"sort"
Expand Down Expand Up @@ -1434,15 +1435,17 @@ outer:
}
}

// Explicitly store files that have changed in the database, if any is present at all.
// This has the benefit that the "Has Changed" attribute will be present as long as the user does not explicitly mark this file as viewed, so it will even survive a page reload after marking another file as viewed.
// On the other hand, this means that even if a commit reverting an unseen change is committed, the file will still be seen as changed.
if len(filesChangedSinceLastDiff) > 0 {
// Explicitly store files that have changed in the database, if any is present at all.
// This has the benefit that the "Has Changed" attribute will be present as long as the user does not explicitly mark this file as viewed, so it will even survive a page reload after marking another file as viewed.
// On the other hand, this means that even if a commit reverting an unseen change is committed, the file will still be seen as changed.
err := pull_model.UpdateReviewState(ctx, review.UserID, review.PullID, review.CommitSHA, filesChangedSinceLastDiff)
if err != nil {
log.Warn("Could not update review for user %d, pull %d, commit %s and the changed files %v: %v", review.UserID, review.PullID, review.CommitSHA, filesChangedSinceLastDiff, err)
return nil, err
}
// Additionally, update the changed files state locally to reflect the changes immediately
maps.Copy(review.UpdatedFiles, filesChangedSinceLastDiff)
}

return review, nil
Expand Down