Skip to content

Conversation

@Sainan
Copy link

@Sainan Sainan commented Nov 4, 2025

It may not be apparent where a custom robots.txt or such should go in the absence of a 'custom' or 'public' folder.

It may not be apparent where a custom robots.txt or such should go in the absence of a 'custom' or 'public' folder.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 4, 2025
Copy link
Member

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I guess a empty folder won't hurt.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 4, 2025
@lunny
Copy link
Member

lunny commented Nov 4, 2025

It seems a unnecessary change and will add two layers for image.

@Sainan
Copy link
Author

Sainan commented Nov 4, 2025

This isn't in the Dockerfile so it will add 0 layers

Copy link
Contributor

@TheFox0x7 TheFox0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that it's less needed in rootless as custom directory is already made in script but overall consistency is probably better.

I think this might be good to add to container docs - that root variant has GITEA_CUSTOM predefined to /data/gitea/ and rootless does not and so it's /var/lib/gitea/custom/ otherwise someone is bound to get confused by this later on.
Alternatively... I wonder if adding a migration in the setup to move it to a proper location is worth it...? GITEA_CUSTOM there feels like it should be GITEA_WORK_DIR instead.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 4, 2025
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry but I don't think we should add more hacky patches to the container images.

The "public" folder is a general requirement for all users, but not only Docker users.

So it should be resolved from code level.

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Nov 5, 2025
@Sainan Sainan closed this Nov 5, 2025
@Sainan Sainan deleted the docker-public branch November 5, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/internal

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants