-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add ALLOWED_ORG_VISIBILITY_MODES setting #34290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
markwylde
wants to merge
5
commits into
go-gitea:main
Choose a base branch
from
markwylde:add-allowed-org-visibility-modes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ALLOWED_ORG_VISIBILITY_MODES setting #34290
markwylde
wants to merge
5
commits into
go-gitea:main
from
markwylde:add-allowed-org-visibility-modes
+273
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to ALLOWED_USER_VISIBILITY_MODES, this setting restricts which visibility modes (public, limited, private) can be selected for organizations. - Added new settings in service.go - Updated settings loading to parse the config - Modified org templates to filter visibility options - Added validation in controllers and service layer - Added translation for error message 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Similar to ALLOWED_USER_VISIBILITY_MODES, this setting restricts which visibility modes (public, limited, private) can be selected for organizations. - Added new settings in service.go - Updated settings loading to parse the config - Modified org templates to filter visibility options - Added validation in controllers and service layer - Added translation for error message - Added tests for configuration loading and validation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
afa57db to
93dd204
Compare
Member
|
The visibility change should be moved to danger zone after #34762 merged which maybe conflicted with this PR. |
Author
|
Thanks @lunny. I've pulled in main and tried to refactor it. Is there anything left to do on this? |
Member
|
Please wait #34814 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
modifies/go
Pull requests that update Go code
modifies/templates
This PR modifies the template files
modifies/translation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #34289
Similar to ALLOWED_USER_VISIBILITY_MODES, this setting restricts which visibility modes (public, limited, private) can be selected for organizations.