Make it possible to delete stale review requests that incorrectly remain in DB #33356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts falsly stayed in DB deleted
GiteaBot
added
the
lgtm/need 2
Member
|
Could you add some tests? |
6543
changed the title
6543
commented
Sep 1, 2025
6543
commented
Sep 1, 2025
6543
commented
Sep 1, 2025
Signed-off-by: 6543 <6543@obermui.de>
6543
commented
Sep 1, 2025
Signed-off-by: 6543 <6543@obermui.de>
6543
changed the title
Member
Author
|
@lunny I did add the tests ... |
lunny
reviewed
Oct 2, 2025
lunny
reviewed
Oct 4, 2025
Member
Author
|
@lunny ping |
lafriks
approved these changes
Dec 2, 2025
GiteaBot
added
lgtm/need 1
Member
|
unit test failure is related. |
Member
Author
Member
Author
|
just reverted it on the wrong branch :/ |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 3, 2025
* giteaofficial/main: Enable TypeScript `strictNullChecks` (go-gitea#35843) Update go toolchain to 1.25.5 (go-gitea#36074) Revert "adopt changes" (was intendet for go-gitea#33356) adopt changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... filter dismissed via SQL more
for tests just create this database entry:
currently I discover this edgecases in the wild :/
with this patch the review request can still be deleted
Sponsored by Kithara Software GmbH