Skip to content

refactor webhook *NewPost #20729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6543 merged 9 commits into from
Aug 11, 2022
Merged

refactor webhook *NewPost #20729

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3138353
refactor webhook *NewPost
oliverpool Aug 9, 2022
8eec61f
remove empty values
oliverpool Aug 9, 2022
d70c104
always show errs.Message
oliverpool Aug 9, 2022
a2a1dc6
remove utils.IsValidSlackChannel
oliverpool Aug 9, 2022
8a10311
move IsValidSlackChannel to services/webhook package
oliverpool Aug 9, 2022
9f09545
binding: handle empty Message case
oliverpool Aug 9, 2022
8dd4ff8
Merge branch 'main' into refactor_webhook_new_post
6543 Aug 9, 2022
24c6d90
make IsValidSlackChannel more strict
oliverpool Aug 11, 2022
a930870
Merge branch 'main' into refactor_webhook_new_post
6543 Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/web/middleware/binding.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,14 @@ func Validate(errs binding.Errors, data map[string]interface{}, f Form, l transl
case validation.ErrRegexPattern:
data["ErrorMsg"] = trName + l.Tr("form.regex_pattern_error", errs[0].Message)
default:
data["ErrorMsg"] = l.Tr("form.unknown_error") + " " + errs[0].Classification
msg := errs[0].Classification
if msg == "" {
msg = errs[0].Message
}
if msg == "" {
msg = l.Tr("form.unknown_error")
}
data["ErrorMsg"] = trName + ": " + msg
}
return errs
}
Expand Down
Loading