Skip to content

Conversation

@genintho
Copy link
Collaborator

@genintho genintho commented Dec 4, 2024

Class using untyped constant are breaking the parser when using 8.3

class Foo { 
const CONSTANT = "Hello world!"; 
}

The problem came from read_optional_type which was returning a "type" even if the statement did not have a type.

Copy link
Collaborator

@czosel czosel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this @genintho!

@czosel czosel merged commit 9c5902b into glayzzle:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants