Fix repo-memory subdirectory support and metrics collector paths

[Copilot]

Fix Metrics Collection Infrastructure

Root Cause Analysis

Issue 1: Incorrect Directory Path in Workflow Instructions ✅

The metrics-collector.md workflow instructions told the agent to write files to:

/tmp/gh-aw/repo-memory-default/memory/meta-orchestrators/metrics/

But the correct path based on the memory ID "default" is:

/tmp/gh-aw/repo-memory-default/memory/default/metrics/

Confusion: The branch-name: memory/meta-orchestrators is the git branch name, NOT the directory path. The directory path format is always /tmp/gh-aw/repo-memory-{ID}/memory/{ID}/.

Issue 2: Push Script Doesn't Handle Subdirectories ✅

The push_repo_memory.cjs script only read top-level files and skipped directories, meaning files in subdirectories like metrics/daily/*.json were never pushed to the git branch.

Fixes Applied

• Fix Issue 1: Update metrics-collector.md with correct directory paths
• Fix Issue 2: Update push_repo_memory.cjs to recursively handle subdirectories
• Fix Issue 2: Update push_repo_memory.cjs file-glob filtering with ** wildcard support
• Update workflow-health-manager.md with correct paths
• Add comprehensive tests for subdirectory support (2254 tests passing)
• Update file-glob pattern to metrics/** for better compatibility
• Merge main branch with updated build system (twice)

Changes Made

1. Enhanced push_repo_memory.cjs

• Added recursive directory scanning
• Implemented ** wildcard support for file-glob patterns
• Preserve directory structure when copying files
• Enhanced pattern matching to support relative paths

2. Updated Workflow Instructions

• Fixed all references from /memory/meta-orchestrators/ to /memory/default/
• Updated metrics-collector.md, workflow-health-manager.md
• Changed file-glob pattern from metrics/**/* to metrics/**

3. Comprehensive Testing

• Added 6 new test cases for subdirectory glob patterns
• Verified ** wildcard functionality
• Security tests for directory traversal prevention
• All 2254 JavaScript tests passing

4. Main Branch Merges

• First merge: Integrated new build system (JS files in actions/setup/js only)
• Second merge: Added duplicate step validation to catch compiler bugs
• All 124 workflows recompiled successfully after each merge

Success Criteria

✅ Metrics Collector will run successfully with fixed paths
✅ Subdirectory files (metrics/daily/*.json) will be pushed to git branch
✅ File-glob patterns correctly filter files with ** support
✅ Workflow Health Manager can access metrics at correct location
✅ All tests passing
✅ Merged with main branch (twice - fully up to date)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>🚨 P0: Metrics Collection Infrastructure Not Operational</issue_title>
<issue_description>## Problem

The Metrics Collector workflow infrastructure is not producing expected output, preventing all meta-orchestrators from performing health analysis.

Missing Data

1. Latest metrics file not found: /tmp/gh-aw/repo-memory-default/memory/meta-orchestrators/metrics/latest.json
2. Historical metrics unavailable: /tmp/gh-aw/repo-memory-default/memory/meta-orchestrators/metrics/daily/*.json
3. Repo memory access denied: Permission issues accessing shared memory paths

Impact

All meta-orchestrators affected:

• ❌ Workflow Health Manager - Cannot assess workflow success rates or detect failures
• ❌ Agent Performance Analyzer - Cannot analyze agent quality trends
• ❌ Campaign Manager - Cannot track campaign health metrics
• ❌ Other workflows depending on shared metrics infrastructure

Without metrics data, we cannot:

• Detect failing workflows proactively
• Calculate success rates or MTBF
• Identify error patterns
• Track performance trends
• Make data-driven optimization decisions

Root Cause Analysis Needed

Possible Issues

1. Metrics Collector workflow failing

   • Not running on schedule (daily)
   • Encountering errors during execution
   • Timeout or resource constraints

2. Repo memory configuration

   • Branch memory/meta-orchestrators not accessible
   • Permission issues on repo-memory tool
   • File path or glob pattern misconfiguration

3. File system permissions

   • /tmp/gh-aw/repo-memory-default/ permissions incorrect
   • Memory mount not working in workflow environment

Investigation Steps

1. Check Metrics Collector status

   gh run list --workflow=metrics-collector.md --limit 10

2. Review recent run logs

   gh run view (run-id) --log

3. Verify repo-memory branch

   git ls-remote origin memory/meta-orchestrators

4. Test repo-memory access

   • Run simple workflow that writes to repo-memory
   • Verify files are committed to branch

Expected Metrics Format

The Metrics Collector should produce:

latest.json:

{
  "timestamp": "2025-12-26T00:00:00Z",
  "workflows": {
    "workflow-name": {
      "total_runs": 10,
      "successful_runs": 8,
      "failed_runs": 2,
      "success_rate": 0.80,
      "avg_duration_seconds": 120
    }
  }
}

daily/YYYY-MM-DD.json: Same format, one per day for 30 days

Recommended Fix

1. Verify Metrics Collector workflow is running successfully
2. Fix repo-memory permissions if access is blocked
3. Update metrics collection if format changed
4. Document metrics schema for consistency across meta-orchestrators

Priority Justification

P0 (Critical) because:

• Blocks all meta-orchestrator health monitoring
• Prevents proactive failure detection across 124 workflows
• No workaround available - metrics are foundation for health assessment
• Affects entire agentic workflow ecosystem reliability

Success Criteria

✅ Metrics Collector runs successfully on daily schedule
✅ latest.json appears in expected location
✅ Historical daily metrics available for 30-day analysis
✅ Workflow Health Manager can access and parse metrics
✅ All meta-orchestrators resume normal operation

---

Discovered by: Workflow Health Manager
Run ID: 20514768306
Date: 2025-12-26 02:53 UTC

AI generated by Workflow Health Manager - Meta-Orchestrator

Comments on the Issue (you are @copilot in this section)

• Fixes 🚨 P0: Metrics Collection Infrastructure Not Operational #7687

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[pelikhan]

@copilot merge main

[pelikhan]

@copilot merge main

[Copilot]

@copilot merge main

Merged main branch successfully in commit 20d9f84.

Resolved merge conflicts by:

• Accepting deletion of pkg/workflow/js/*.cjs files (build system now uses source files in actions/setup/js/ directly)
• Preserving custom changes to push_repo_memory.cjs for subdirectory support
• Recompiling all 124 workflows with the new build system

All workflows compiled successfully.

[Copilot]

@copilot merge main

Merged latest main branch successfully in commit dd0498e.

Integrated changes:

• Duplicate step validation to catch compiler bugs (Add duplicate step validation to catch compiler bugs in lock.yml generation #7693)
• Recompiled all 124 workflows successfully

The branch is now fully up to date with main.