feat(control-plane): tag controll plane created SSM Parameters (#4833) #4834
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for tagging AWS SSM Parameter Store parameters by adding a new parameter_store_tags variable that allows users to specify custom tags to be applied to all SSM parameters created by the Lambda functions.
- Adds a new
parameter_store_tagsvariable across all modules to accept user-defined tags - Updates Lambda functions to read and apply these tags when creating SSM parameters
- Transforms the tag map into the required format for AWS SSM API calls
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| variables.tf | Adds new parameter_store_tags variable definition at root level |
| modules/runners/variables.tf | Adds parameter_store_tags variable to runners module |
| modules/runners/local.tf | Creates local transformation to convert tag map to AWS format |
| modules/runners/scale-up.tf | Passes transformed tags to scale-up Lambda environment |
| modules/runners/pool/ | Updates pool module to handle parameter store tags |
| modules/multi-runner/ | Adds parameter store tags support to multi-runner module |
| main.tf | Passes parameter store tags variable to runners module |
| lambdas/ | Updates Lambda functions to parse and apply tags to SSM parameters |
| README.md files | Updates documentation to include new parameter store tags variable |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@wadherv thx for your PR, I wont have no option to check open PRs till the end of the month, sorry for the delay |
|
Working my way to my backlog, thx for the reminder |
npalm
changed the title
| }); | ||
| await putParameter(`${githubRunnerConfig.ssmTokenPath}/${instance}`, runnerConfig.data.encoded_jit_config, true, { | ||
| tags: [{ Key: 'InstanceId', Value: instance }], | ||
| tags: [{ Key: 'InstanceId', Value: instance }, ...githubRunnerConfig.ssmParameterStoreTags], |
There was a problem hiding this comment.
The change was not working, made a suggestion to locals.tf. But effect was this line was casuign an exception since the tags were not proper formatted. The change in locals.tf is fixing this. Although if you see any option here to validate the tags (without API) call as safe gurd that woudl be great.
There was a problem hiding this comment.
added
to validate the tagsCo-authored-by: Niek Palm <npalm@users.noreply.github.com>
2 participants
Introducing a new variable
parameter_store_tagsto add tags for all the SSM Parameter Store resources created via Scale-Up and Pool lambda function.