Skip to content

Conversation

@Rojoss
Copy link
Contributor

@Rojoss Rojoss commented Feb 18, 2016

Added a new modal component.
It supports pretty much everything from the bootstrap modal.
I didn't add footer stuff as panels don't have them either and I'd have to create a seperate syntax for it probably for it to look nice.
If you want me to do that then I'll do that but I think it's fine like this.

You can see them in action here:
http://gameboxx.info/wiki/bootstrap/modal

I've also added a modal attribute to buttons to be able to open the modals similar to the collapse attribute.

giterlizzi added a commit that referenced this pull request Feb 19, 2016
Added new modal component (thanks to @Rojoss)
@giterlizzi giterlizzi merged commit 7dc780c into giterlizzi:master Feb 19, 2016
@giterlizzi
Copy link
Owner

Good job!

@Rojoss
Copy link
Contributor Author

Rojoss commented Feb 19, 2016

Thnx for accepting the pr's.
Sorry for the format/indenting btw my IDE doesn't seem to like 2 space indenting and stuff.
I've set it to two spaces but it still uses 4 for some reason. :p

I've started on #33 btw.
You can see it in action on this page:
http://gameboxx.info/wiki/styling

If you have feedback on it please let me know.
Will create a PR later tonight probably.

You can see the changes so far here:
master...Rojoss:pr-styling

@Rojoss
Copy link
Contributor Author

Rojoss commented Feb 19, 2016

I've created a PR for it already. #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants