Skip to content

Add Ubuntu 22.04 builds and upgrade core Linux dependencies #11412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
slarse wants to merge 5 commits into
base: master
Choose a base branch
from
+17 −1
Draft

Add Ubuntu 22.04 builds and upgrade core Linux dependencies #11412

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6aa0fa6
Add Ubuntu 22.04 builds
slarse Nov 30, 2025
74b8525
Upgrade build dependencies
slarse Nov 30, 2025
5f9f531
Make the rust-cache specific to the platform when publishing.
Byron Dec 1, 2025
2df80e9
Revert "Upgrade build dependencies"
slarse Dec 3, 2025
dd2164e
Add distro codename into RELEASE_DIR path for linux
slarse Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ jobs:
target: ''
- platform: ubuntu-24.04-arm # [linux, ARM64]
target: ''
- platform: ubuntu-22.04 # [linux, x64]
target: ''
- platform: ubuntu-22.04-arm # [linux, ARM64]
target: ''
Comment on lines +105 to +106
Copy link
Contributor Author

@slarse slarse Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in OP, I'm really unsure if this build is desirable.

- platform: windows-latest # [windows, x64]
target: ''

Expand Down Expand Up @@ -172,6 +176,7 @@ jobs:
if: runner.os == 'Linux'
run: |
sudo apt update;
sudo apt upgrade;
Copy link
Contributor Author

@slarse slarse Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base image for the runner is most often outdated, I think it makes sense to ensure that we get the latest and greatest of everything that's installed for whichever distro we're building for.

sudo apt install -y \
build-essential \
curl \
Expand All @@ -184,12 +189,12 @@ jobs:
xdg-utils;

sudo apt install -y \
libwebkit2gtk-4.1-0=2.44.0-2 \
libwebkit2gtk-4.1-dev=2.44.0-2 \
libjavascriptcoregtk-4.1-0=2.44.0-2 \
libjavascriptcoregtk-4.1-dev=2.44.0-2 \
gir1.2-javascriptcoregtk-4.1=2.44.0-2 \
gir1.2-webkit2-4.1=2.44.0-2;
'libwebkit2gtk-4.1-0=2.50.*' \
'libwebkit2gtk-4.1-dev=2.50.*' \
'libjavascriptcoregtk-4.1-0=2.50.*' \
'libjavascriptcoregtk-4.1-dev=2.50.*' \
'gir1.2-javascriptcoregtk-4.1=2.50.*' \
'gir1.2-webkit2-4.1=2.50.*';
Copy link
Contributor Author

@slarse slarse Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe locking down on the minor version is a good enough tradeoff. That way, we get patches as well as Debian/Ubuntu-specific changes automatically, while minimizing risk that we get a breaking update.

Minor version bumps in libwebkit does seem to introduce drastic changes, so I think it's a good idea to perform such updates under more controlled forms.


- uses: actions/download-artifact@v6
name: Download SvelteKit build output
Expand Down Expand Up @@ -352,6 +357,10 @@ jobs:
target: ''
- platform: ubuntu-24.04-arm # [linux, ARM64]
target: ''
- platform: ubuntu-22.04 # [linux, x64]
target: ''
- platform: ubuntu-22.04-arm # [linux, ARM64]
target: ''
- platform: windows-latest # [windows, x64]
target: ''
steps:
Expand Down
Loading