Do not persist credentials during checkout to prevent exfiltration or accidental logging #10399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accidental logging Based on this commit in Gitoxide: GitoxideLabs/gitoxide@a235ac8
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
`publish.yaml` is excluded just because testing it is more cumbersome, and it's nothing that untrusted parties can easily run.
Collaborator
Author
|
CC @krlvi This PR is a clone of a similar one in
|
Member
|
Nice one, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this commit in Gitoxide:
GitoxideLabs/gitoxide@a235ac8
Tasks
Note that the exception of
publish.ymlis merely done out of fear of testing this, as it's possible thatthis workflow relies on persisted credentials.