add configurable minimum prefix length for search queries #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature addresses the issue of overly broad search matches from very short prefixes by introducing a configurable minimum length requirement for prefix-based searches. Changes: - Added 'min_prefix_length' configuration option (default: 3) - Updated Tokens::prefixes() to accept minLength parameter - Modified HasEncryptedSearchIndex to enforce minimum length during: - Token generation (indexing) - Query execution (searching) - Added comprehensive test coverage (10 new feature tests, 6 unit tests) Behavior: - With min_prefix_length=3 (default): - Searching for "Wi" (2 chars) returns no results - Searching for "Wil" (3+ chars) works normally - Prevents performance issues from single-character searches - Reduces false positives from very short search terms - Exact search is unaffected by this setting Benefits: - Eliminates unwanted matches (e.g., "W" matching "William", "Wendy", "Walter") - Improves search precision - Maintains backwards compatibility (set to 1 for old behavior) - Configurable per environment via ENCRYPTED_SEARCH_MIN_PREFIX Test updates: - Updated existing tests to use min_prefix_length=1 for compatibility - Added MinimumPrefixLengthTest with 10 comprehensive scenarios - Added 6 unit tests for Tokens class minimum length behavior - All 76 tests passing (136 assertions)
ginkelsoft-development
added a commit
that referenced
this pull request
Oct 14, 2025
…efix-length add configurable minimum prefix length for search queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature addresses the issue of overly broad search matches from very short prefixes by introducing a configurable minimum length requirement for prefix-based searches.
Changes:
Behavior:
Benefits:
Test updates: