Fixes to generate valid C# bindings for Terrain3D and GodotSteam extensions (and hopefully more) #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (and hopefully more) -Fix invalid code generated with Vector2/Vector3/Transform2D/Transform3D structs when using default nullable args -Fix casting of enums in a few places -Added required casts for doubles to floats in generated code -Prefix consts if they conflict with names of properties -Prefix event/signals if they conflict with names of methods -Fix generated using system object instead of GodotObject -Fix invalid code generated with godot arrays holding a non-variant objects -Fix 3d -> 3D naming mapping in godot C# code -Added invalid class cast guards to binding code -Support for casting directly from engine class -Postfix enums names that start with a number
LukePH
changed the title
LukePH
changed the title
Owner
|
Hey @LukePH, thanks for the contribution. It will take me some time to review this PR, but let me address something in the mean time:
Ok, so about this. Contrary to https://github.com/Delsin-Yu/CSharp-Wrapper-Generator-for-GDExtension, the C# code generated by this project does not inherit from GodotObject because the generated classes are supposed to be mere wrappers over the actual instances instead of being full-blown C# scripts that can be attached to objects in Godot. I'm not sure why you had to change this, I'm quite curious about this specifically 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fix invalid code generated with Vector2/Vector3/Transform2D/Transform3D structs when using default nullable args
-Fix casting of enums in a few places
-Added required casts for doubles to floats in generated code
-Prefix consts if they conflict with names of properties
-Prefix event/signals if they conflict with names of methods
-Fix generated using system object instead of GodotObject
-Fix invalid code generated with godot arrays holding a non-variant objects
-Fix 3d -> 3D naming mapping in godot C# code
-Added invalid class cast guards to binding code
-Support for casting directly from engine class
-Postfix enums names that start with a number