vad : fix buffer overflow in sample reduction loop #3558
Merged
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix heap corruption crash in VAD processing caused by buffer overflow in the sample reduction loop.
Problem
The buffer size calculation loop (line ~6661) uses
n_samples - 1as the upper bound:segment_end_samples = std::min(segment_end_samples, n_samples - 1); filtered_n_samples += (segment_end_samples - segment_start_samples);But the copy loop (line 6696) uses
n_samples:This allows
segment_lengthto be up to 1 sample larger per segment than what was allocated, causing writes past the end offiltered_samplesbuffer.Symptom
malloc(): corrupted top sizemalloc(): invalid size (unsorted)whisper_vad: Reduced audio from X to Y samplesFix
Use consistent bounds (
n_samples - 1) in both loops.Fixes #3403