examples: add -g/--gpu-device option and GPU_DEVICE env support #3557
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `-g` / `--gpu-device` CLI option to select a specific GPU device. - Added support for `GPU_DEVICE` environment variable as a fallback. - Updated `whisper_params` to store the `gpu_device` index. - Passed the selected device ID to `whisper_context_params` initialization. - Applied changes to both `examples/cli/cli.cpp` and `examples/server/server.cpp`.
danbev
reviewed
Dec 6, 2025
| else if (arg == "-dtw" || arg == "--dtw") { params.dtw = ARGV_NEXT; } | ||
| else if (arg == "-ls" || arg == "--log-score") { params.log_score = true; } | ||
| else if (arg == "-ng" || arg == "--no-gpu") { params.use_gpu = false; } | ||
| else if (arg == "-g" || arg == "--gpu-device") { params.gpu_device = std::stoi(ARGV_NEXT); } |
Member
There was a problem hiding this comment.
Perhaps we should use --device here to be consistent with llama.cpp.
| } | ||
|
|
||
| bool whisper_params_parse(int argc, char ** argv, whisper_params & params, server_params & sparams) { | ||
| if (const char * env_gpu_device = std::getenv("GPU_DEVICE")) { |
Member
There was a problem hiding this comment.
And perhaps this should be WHISPER_ARG_DEVICE to be consistent with llama.cpp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-g/--gpu-deviceCLI option to select a specific GPU device.GPU_DEVICEenvironment variable as a fallback.whisper_paramsto store thegpu_deviceindex.whisper_context_paramsinitialization.examples/cli/cli.cppandexamples/server/server.cpp.