Skip to content

ci : skip winget update when not in ggml-org #17465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CISC merged 1 commit into from
Dec 2, 2025
Merged

ci : skip winget update when not in ggml-org #17465

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/winget.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ jobs:
update:
name: Update Winget Package
runs-on: ubuntu-latest
if: ${{ github.repository.owner.login == 'ggml-org' }}
Copy link
Member

@slaren slaren Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could check if secrets.WINGET_GITHUB_TOKEN exists instead.

Copy link
Collaborator Author

@angt angt Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just found my last comment disappeared (I did something wrong with github I guess..) so let me resume my last comment:

Checking secrets.WINGET_GITHUB_TOKEN would not fix my issue as the build will fail before for various reasons (no release, no tags, etc).

But also this step has no value outside of ggml-org and explicitly use it:

llama.cpp/.github/workflows/winget.yml

Line 39 in 6ab4e50

--urls "https://github.com/ggml-org/llama.cpp/releases/download/${{ env.VERSION }}/llama-${{ env.VERSION }}-bin-win-vulkan-x64.zip" \

In the scenario where the action is performed under ggml-org, I believe a red notification would be beneficial if the secret is missing.


steps:
- name: Install cargo binstall
Expand Down
Loading