Don't generate a BufferTextureCopy::rows_per_image if None was specified
#8673
+9
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8668
Description
When we generate a fallback value, it causes the gles backend to set
UNPACK_IMAGE_HEIGHTto a non-zero value, which causes Firefox to log a warning and not write... sometimes. But None does seem to be the correct value for 1D/2D textures.Testing
I've tested it manually in context of the app I'm building, but I haven't managed to come up with a self contained test case. There's clearly some other state or something in Firefox that leads to this actually triggering a malfunction.
I'm not quite sure how to add an automated test. Is it practical to write a test where we read back the
UNPACK_IMAGE_HEIGHT?If we're nervous about side effects, I could scope this down to be done just within the gles backend by checking for
dst_target == glow::TEXTURE_2Dand forcing theUNPACK_IMAGE_HEIGHTvalue to 0 in https://github.com/gfx-rs/wgpu/blob/trunk/wgpu-hal/src/gles/queue.rs#L754Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.