hal/vulkan: Fix multi draw indirect emulating and respect maxDrawIndirectCount
#8665
+38
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noted this when I was checking #8162
The offset argument of
draw_indexed_indirectin hal/vulkan seems incorrect. It should+ i * stride.Also multi draw indirect should respect limits.maxDrawIndirectCount.
Actually,
vkCmdDrawIndirectCountvkCmdDrawIndexedIndirectCountvkCmdDrawMeshTasksIndirectCountEXTalso require that the count in the countBuffer must be <= maxDrawIndirectCount, altough on many devices it'su32::MAX(vulkan gpuinfo)Testing
I assume the code is correct, I don't have a device to test this.
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.