Add command line flag to disable cookies #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2020 18:01
Passes cookie=false option to socket.io which stops cookie's being set for clients.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the discovery-swarm-webrtc server, the socket.io defaults set a cookie. These cookies, however, do not set
samSiteflags, causing warnings in modern browsers:This PR makes two changes:
--no-cookieoption to the command line interface, that stops socket.io from setting cookies.sameSite=strict, which will suppress browser warnings: https://github.com/socketio/engine.io/releases/tag/3.4.1