-
Notifications
You must be signed in to change notification settings - Fork 22
SDK-2767: Add token-based authentication strategy alongside PEM signing #386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
3
commits into
feature/SDK-2767-support-central-auth-tokens
Choose a base branch
from
copilot/sub-pr-385
base: feature/SDK-2767-support-central-auth-tokens
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SDK-2767: Add token-based authentication strategy alongside PEM signing #386
Copilot
wants to merge
3
commits into
feature/SDK-2767-support-central-auth-tokens
from
copilot/sub-pr-385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mehmet-yoti <111424390+mehmet-yoti@users.noreply.github.com>
Co-authored-by: mehmet-yoti <111424390+mehmet-yoti@users.noreply.github.com>
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Add support for central auth tokens
SDK-2767: Add token-based authentication strategy alongside PEM signing
Nov 27, 2025
Copilot finished work on behalf of
mehmet-yoti
November 27, 2025 15:50
mehmet-yoti
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Central Auth token support while maintaining backward compatibility with existing PEM-based request signing.
Implementation
Authentication Strategy Pattern
AuthStrategyInterfacewith two implementations:SignedRequestAuthStrategy- wraps existing PEM signing (addsX-Yoti-Auth-Digestheader + nonce/timestamp)TokenAuthStrategy- addsAuthorization: Bearer {token}headerRequestBuilderauto-selects strategy: token ifConfig::AUTH_TOKENset, otherwise PEM signingConfiguration
Config::AUTH_TOKENconstant for token-based authConfig::getAuthToken()returns configured token or nullBackward Compatibility
Usage
Token-based authentication:
Traditional PEM authentication (unchanged):
Explicit strategy override:
Documentation
docs/AUTHENTICATION.md- comprehensive guide covering both auth methods, migration path, and best practicesREADME.mdto reference authentication options✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.