feat(replays) - add playlist support from Issue Details and Insights #103007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imestamps Added functionality to display the start and end timestamps of replays in the ReplayTable and ReplayDetails components. This allows users to navigate between replays with context on their timing, improving the overall user experience. Updated ReplayDetailsUserBadge to include navigation buttons for previous and next replays.
…ed props for next and previous replays in the ReplayDetailsUserBadge component, streamlining the code. Adjusted the loading placeholder height for better visual consistency. This change enhances the component's clarity and performance by eliminating unnecessary complexity
…ation Refactored the ReplayDetails component to use 'undefined' instead of 'null' for next and previous replay checks, enhancing clarity. Updated ReplayDetailsPageBreadcrumbs to include navigation buttons for previous and next replays, improving user experience by allowing seamless navigation between replays. This change streamlines the code and enhances the overall functionality of the replay details view.
Replaced the 'Next' icon in ReplayPlayPauseBar with 'IconChevron' for improved clarity. Refactored ReplayDetailsPageBreadcrumbs to utilize 'ButtonBar' for previous and next replay navigation buttons, enhancing the user interface and experience. This change streamlines the navigation between replays, making it more intuitive for users.
…d components Refactored the ReplayTable component to streamline the handling of replay start times by removing the end timestamp logic. Updated related components to eliminate unnecessary props and improve clarity. This change enhances the overall performance and readability of the replay table, making it easier to manage replay data.
…ameters - Imported `encodeSort` from `eventView` to handle sorting in the replay table. - Updated the `ReplaySessionColumn` to utilize the new sorting mechanism without modifying the URL directly. - Refactored query parameters in `ReplayDetails` to include `playlistStart` and improved handling of the `sort` parameter using `useUrlParams`. - Exported `DEFAULT_SORT` from `useReplayTableSort` for broader accessibility.
Updated the replay table component to calculate and pass the latest replay timestamp as 'end' instead of 'start'. Adjusted related components and queries to reflect this change, ensuring consistency across the application.
Clarified the comment in the ReplaySessionColumn regarding how EventView fetches the sort parameter from the URL, ensuring better understanding of the code's functionality.
…andling. Eliminated the calculation of the latest replay timestamp in the ReplayTable component, as it was no longer needed. Updated the ReplaySessionColumn to handle the event view query without the end parameter using exclusively the statsPeriod, ensuring cleaner code and improved clarity in the query string management.
…omponents Added EventView support to the ReplayTable component, allowing for enhanced query handling and sorting. Updated the ReplayDetailsLinkColumn to utilize EventView for constructing query parameters, ensuring a more dynamic interaction with replay data. Adjusted the GroupReplays component to pass the eventView prop, improving overall functionality and user experience.
…es. Updated the logic in the ReplayDetails component to ensure that the next replay is only accessed when the current index is valid, preventing potential out-of-bounds errors.
… integration. Updated ReplayTableColumns to include a new function for generating query strings that incorporates the stats period, ensuring accurate date range handling in replay links.
… and end dates when stats period is provided, improving date range handling in replay links.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…ueryReferrer and update queryReferrer mapping in ReplayDetailsProviders
static/app/views/replays/detail/body/replayDetailsProviders.tsx
Outdated
Show resolved
Hide resolved
billyvg
reviewed
Nov 17, 2025
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
Would it make more sense to call usePlaylistQuery at our route level components? (e.g. groupReplays, transactionReplays) and pass the query string down?
That way, the more generic components like replayTable don't need to about playlist query params, they are just forwarding them.
static/app/components/events/eventReplay/replayClipPreview.spec.tsx
Outdated
Show resolved
Hide resolved
static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx
Outdated
Show resolved
Hide resolved
…of eventView, enhancing consistency across components
…e clarity in usePlaylistQuery
…or improved clarity and consistency
jerryzhou196
commented
Nov 17, 2025
static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx
Outdated
Show resolved
Hide resolved
jerryzhou196
commented
Nov 17, 2025
static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx
Outdated
Show resolved
Hide resolved
jerryzhou196
commented
Nov 17, 2025
static/app/views/performance/transactionSummary/transactionReplays/index.spec.tsx
Outdated
Show resolved
Hide resolved
static/app/views/replays/detail/body/replayDetailsProviders.tsx
Outdated
Show resolved
Hide resolved
…s to ensure fallback value is used
billyvg
reviewed
Nov 17, 2025
static/app/views/issueDetails/groupReplays/groupReplays.spec.tsx
Outdated
Show resolved
Hide resolved
… related tests for improved clarity
billyvg
approved these changes
Nov 17, 2025
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
Tested:
- issues stream
- issues detail
- issues detail -> replays section
- transaction summary
Seems to work well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #102583
Issue Details:
Performance:
