-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(aci): Add missing anomaly detection conditions #103004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apparently we were missing these entirely. Also fixes some issues when editing an existing anomaly detector
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
| ? detector.config.thresholdType | ||
| : DEFAULT_THRESHOLD_METRIC_FORM_DATA.thresholdType, | ||
| // Dynamic fields - extract from anomaly detection condition for dynamic detectors | ||
| sensitivity: anomalyCondition.sensitivity, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also be removed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this one is sensitivity
| interface MetricDetectorConfigDynamic { | ||
| detectionType: 'dynamic'; | ||
| seasonality?: 'auto' | 'daily' | 'weekly' | 'monthly'; | ||
| sensitivity?: 'low' | 'medium' | 'high'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sensitivity needs to be removed too 😅
Apparently we were missing these entirely. Also fixes some issues when editing an existing anomaly detector and cleans up an unused config value.
Apparently we were missing these entirely. Also fixes some issues when editing an existing anomaly detector and cleans up an unused config value.
Apparently we were missing these entirely. Also fixes some issues when editing an existing anomaly detector and cleans up an unused config value.