-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
feat: Add Python examples to Spans v2 API page #15650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Lms24
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! good reminder for me to document the actual JS API as well and move the current example to pseudocode or some kind of ideal blueprint example.
|
|
||
| ```Python {tabTitle:Python} | ||
|
|
||
| with sentry_sdk.start_span(name="checkout", attributes={"user.id": "123"}) as checkout_span: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Can sentry_sdk.start_span be used without a with statement?
If so, could we write down an example for this? I think it's fully okay to support with (or callbacks or whatever the platform prefers) but ideally we can also document the most simple case which is that start_span returns an active span which users end manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty, added in 33bad41.
Preview: https://develop-docs-git-ivana-add-py-example-to-spans-v2-api.sentry.dev/sdk/telemetry/spans/span-api/
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES