Skip to content

chore(preprod): Capture scale info for parsedassets #3029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NicoHinderling wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(preprod): Capture scale info for parsedassets #3029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...rsing/native/swift/AssetCatalogParser/Sources/AssetCatalogParser/AssetCatalogReader.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ struct AssetCatalogEntry: Encodable {
let idiom: String?
let colorspace: String?
let contentHash: String?
let scale: UInt?
}

enum Error: Swift.Error {
Expand Down Expand Up @@ -240,6 +241,7 @@ enum AssetUtil {

let idiomValue = key.getUInt(forKey: "themeIdiom")
let colorSpaceID = rendition.getUInt(forKey: "colorSpaceID")
let scaleValue = key.getUInt(forKey: "themeScale")

// Include multisize set name in the name field if it exists
let finalName: String
Expand All @@ -260,7 +262,8 @@ enum AssetUtil {
type: assetType,
idiom: idiomToString(idiomValue),
colorspace: colorSpaceIDToString(colorSpaceID),
contentHash: contentHash
contentHash: contentHash,
scale: scaleValue
)
assets.append(asset)
}
Expand All @@ -276,7 +279,8 @@ enum AssetUtil {
type: nil,
idiom: nil,
colorspace: nil,
contentHash: nil
contentHash: nil,
scale: nil
))

let data = try! JSONEncoder().encode(assets)
Expand Down