refactor: Remove duplicate tooling metadata extraction (EME-606)

Removed duplicate metadata extraction logic from artifact_processor.py
since the tooling versions are already extracted by the platform analyzers
using the dedicated metadata_extractor.py utility. The values are available
via the app_info object, eliminating the need for redundant extraction.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: runningcode

src/launchpad/api/update_api_models.py

@@ -64,8 +64,12 @@ class UpdateData(BaseModel):
     android_app_info: Optional[AndroidAppInfo] = None
     dequeued_at: Optional[datetime] = Field(None, description="Timestamp when message was dequeued from Kafka")
     cli_version: Optional[str] = Field(None, description="sentry-cli version extracted from .sentry-cli-metadata.txt")
-    fastlane_plugin_version: Optional[str] = Field(None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt")
-    gradle_plugin_version: Optional[str] = Field(None, description="Gradle plugin version extracted from .sentry-cli-metadata.txt")
+    fastlane_plugin_version: Optional[str] = Field(
+        None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt"
+    )
+    gradle_plugin_version: Optional[str] = Field(
+        None, description="Gradle plugin version extracted from .sentry-cli-metadata.txt"
+    )
 
     @field_serializer("dequeued_at")
     def serialize_datetime(self, dt: datetime | None) -> str | None:

src/launchpad/artifact_processor.py

@@ -411,41 +411,6 @@ def _update_size_error(
         except SentryClientError:
             logger.exception(f"Failed to update artifact with error {message}")
 
-    def _extract_tooling_versions(self, artifact: Artifact) -> Dict[str, str | None]:
-        """Extract tooling version information from the artifact zip file.
-
-        Looks for metadata files like .sentry-cli-metadata.txt in the zip
-        and extracts version information.
-
-        Returns:
-            Dict with keys: sentry_cli_version, fastlane_plugin_version, gradle_plugin_version
-        """
-        import zipfile
-
-        versions = {
-            "sentry_cli_version": None,
-            "fastlane_plugin_version": None,
-            "gradle_plugin_version": None,
-        }
-
-        try:
-            with zipfile.ZipFile(artifact.path, "r") as zf:
-                # Look for .sentry-cli-metadata.txt in the root of the zip
-                if ".sentry-cli-metadata.txt" in zf.namelist():
-                    with zf.open(".sentry-cli-metadata.txt") as f:
-                        content = f.read().decode("utf-8")
-                        # Parse format: sentry-cli-version: {version}
-                        for line in content.strip().split("\n"):
-                            if line.startswith("sentry-cli-version:"):
-                                version = line.split(":", 1)[1].strip()
-                                versions["sentry_cli_version"] = version
-                                logger.debug(f"Extracted sentry-cli version: {version}")
-                                break
-        except Exception as e:
-            logger.debug(f"Could not extract tooling versions: {e}")
-
-        return versions
-
     def _prepare_update_data(
         self,
         app_info: AppleAppInfo | BaseAppInfo,
@@ -485,9 +450,6 @@ def _get_artifact_type(artifact: Artifact) -> ArtifactType:
                 has_proguard_mapping=app_info.has_proguard_mapping,
             )
 
-        # Extract tooling versions from the artifact metadata
-        tooling_versions = self._extract_tooling_versions(artifact)
-
         update_data = UpdateData(
             app_name=app_info.name,
             app_id=app_info.app_id,

src/launchpad/size/models/common.py

@@ -29,8 +29,12 @@ class BaseAppInfo(BaseModel):
     build: str = Field(..., description="Build number")
     app_id: str = Field(..., description="App ID (bundle id on iOS, package name on Android)")
     cli_version: str | None = Field(None, description="sentry-cli version extracted from .sentry-cli-metadata.txt")
-    fastlane_plugin_version: str | None = Field(None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt")
-    gradle_plugin_version: str | None = Field(None, description="Gradle plugin version extracted from .sentry-cli-metadata.txt")
+    fastlane_plugin_version: str | None = Field(
+        None, description="Fastlane plugin version extracted from .sentry-cli-metadata.txt"
+    )
+    gradle_plugin_version: str | None = Field(
+        None, description="Gradle plugin version extracted from .sentry-cli-metadata.txt"
+    )
 
 
 class FileAnalysis(BaseModel):

src/launchpad/utils/metadata_extractor.py

@@ -65,8 +65,8 @@ def _parse_metadata_content(content: str) -> ToolingMetadata:
 
     Expected format:
         sentry-cli-version: 2.58.2
-        fastlane-plugin-version: 1.2.3
-        gradle-plugin-version: 4.12.0
+        sentry-fastlane-plugin: 1.2.3
+        sentry-gradle-plugin: 4.12.0
 
     Args:
         content: The text content of the metadata file
@@ -89,6 +89,6 @@ def _parse_metadata_content(content: str) -> ToolingMetadata:
 
     return ToolingMetadata(
         cli_version=metadata.get("sentry-cli-version"),
-        fastlane_plugin_version=metadata.get("fastlane-plugin-version"),
-        gradle_plugin_version=metadata.get("gradle-plugin-version"),
+        fastlane_plugin_version=metadata.get("sentry-fastlane-plugin"),
+        gradle_plugin_version=metadata.get("sentry-gradle-plugin"),
     )

tests/unit/artifacts/test_artifact_processor.py

@@ -291,104 +291,3 @@ def test_process_message_project_not_skipped(self, mock_process, mock_sentry_cli
         calls = fake_statsd.calls
         assert ("increment", {"metric": "artifact.processing.started", "value": 1, "tags": None}) in calls
         assert ("increment", {"metric": "artifact.processing.completed", "value": 1, "tags": None}) in calls
-
-
-class TestToolingVersionExtraction:
-    """Test extraction of tooling version information from artifacts."""
-
-    def setup_method(self):
-        """Set up test fixtures."""
-        mock_sentry_client = Mock(spec=SentryClient)
-        mock_statsd = Mock()
-        self.processor = ArtifactProcessor(mock_sentry_client, mock_statsd)
-
-    def test_extract_tooling_versions_with_sentry_cli_version(self, tmp_path):
-        """Test extracting sentry-cli version from artifact zip."""
-        import zipfile
-
-        from launchpad.artifacts.artifact import Artifact
-
-        # Create a test zip file with .sentry-cli-metadata.txt
-        zip_path = tmp_path / "test_artifact.zip"
-        with zipfile.ZipFile(zip_path, "w") as zf:
-            zf.writestr(".sentry-cli-metadata.txt", "sentry-cli-version: 2.39.1\n")
-
-        # Create an artifact pointing to the zip
-        artifact = Artifact(path=zip_path)
-
-        # Extract versions
-        versions = self.processor._extract_tooling_versions(artifact)
-
-        # Verify sentry-cli version was extracted
-        assert versions["sentry_cli_version"] == "2.39.1"
-        assert versions["fastlane_plugin_version"] is None
-        assert versions["gradle_plugin_version"] is None
-
-    def test_extract_tooling_versions_no_metadata_file(self, tmp_path):
-        """Test extracting versions when no metadata file exists."""
-        import zipfile
-
-        from launchpad.artifacts.artifact import Artifact
-
-        # Create a test zip file without metadata
-        zip_path = tmp_path / "test_artifact.zip"
-        with zipfile.ZipFile(zip_path, "w") as zf:
-            zf.writestr("some_file.txt", "content")
-
-        artifact = Artifact(path=zip_path)
-        versions = self.processor._extract_tooling_versions(artifact)
-
-        # All versions should be None
-        assert versions["sentry_cli_version"] is None
-        assert versions["fastlane_version"] is None
-        assert versions["gradle_plugin_version"] is None
-
-    def test_extract_tooling_versions_multiline_metadata(self, tmp_path):
-        """Test extracting version from metadata file with multiple lines."""
-        import zipfile
-
-        from launchpad.artifacts.artifact import Artifact
-
-        zip_path = tmp_path / "test_artifact.zip"
-        with zipfile.ZipFile(zip_path, "w") as zf:
-            metadata_content = """# Sentry CLI Metadata
-sentry-cli-version: 2.40.0
-upload-date: 2025-11-10
-"""
-            zf.writestr(".sentry-cli-metadata.txt", metadata_content)
-
-        artifact = Artifact(path=zip_path)
-        versions = self.processor._extract_tooling_versions(artifact)
-
-        assert versions["sentry_cli_version"] == "2.40.0"
-
-    def test_extract_tooling_versions_with_spaces(self, tmp_path):
-        """Test extracting version with extra whitespace."""
-        import zipfile
-
-        from launchpad.artifacts.artifact import Artifact
-
-        zip_path = tmp_path / "test_artifact.zip"
-        with zipfile.ZipFile(zip_path, "w") as zf:
-            zf.writestr(".sentry-cli-metadata.txt", "sentry-cli-version:   2.39.1   \n")
-
-        artifact = Artifact(path=zip_path)
-        versions = self.processor._extract_tooling_versions(artifact)
-
-        assert versions["sentry_cli_version"] == "2.39.1"
-
-    def test_extract_tooling_versions_invalid_zip(self, tmp_path):
-        """Test graceful handling of invalid/corrupted zip file."""
-        from launchpad.artifacts.artifact import Artifact
-
-        # Create a non-zip file
-        invalid_zip = tmp_path / "invalid.zip"
-        invalid_zip.write_text("not a zip file")
-
-        artifact = Artifact(path=invalid_zip)
-        versions = self.processor._extract_tooling_versions(artifact)
-
-        # Should return all None values without crashing
-        assert versions["sentry_cli_version"] is None
-        assert versions["fastlane_version"] is None
-        assert versions["gradle_plugin_version"] is None

tests/unit/utils/test_metadata_extractor.py

@@ -17,16 +17,16 @@ class TestParseMetadataContent:
 
     def test_parse_all_fields(self):
         content = """sentry-cli-version: 2.58.2
-fastlane-plugin: 1.2.3
-gradle-plugin: 4.12.0"""
+sentry-fastlane-plugin: 1.2.3
+sentry-gradle-plugin: 4.12.0"""
         metadata = _parse_metadata_content(content)
         assert metadata.cli_version == "2.58.2"
         assert metadata.fastlane_plugin_version == "1.2.3"
         assert metadata.gradle_plugin_version == "4.12.0"
 
     def test_parse_partial_fields(self):
         content = """sentry-cli-version: 2.58.2
-fastlane-plugin: 1.2.3"""
+sentry-fastlane-plugin: 1.2.3"""
         metadata = _parse_metadata_content(content)
         assert metadata.cli_version == "2.58.2"
         assert metadata.fastlane_plugin_version == "1.2.3"
@@ -48,8 +48,8 @@ def test_parse_empty_content(self):
 
     def test_parse_with_extra_whitespace(self):
         content = """  sentry-cli-version:  2.58.2
-  fastlane-plugin:  1.2.3
-  gradle-plugin:  4.12.0  """
+  sentry-fastlane-plugin:  1.2.3
+  sentry-gradle-plugin:  4.12.0  """
         metadata = _parse_metadata_content(content)
         assert metadata.cli_version == "2.58.2"
         assert metadata.fastlane_plugin_version == "1.2.3"
@@ -59,9 +59,9 @@ def test_parse_with_extra_lines(self):
         content = """
 sentry-cli-version: 2.58.2
 
-fastlane-plugin: 1.2.3
+sentry-fastlane-plugin: 1.2.3
 
-gradle-plugin: 4.12.0
+sentry-gradle-plugin: 4.12.0
 """
         metadata = _parse_metadata_content(content)
         assert metadata.cli_version == "2.58.2"
@@ -71,7 +71,7 @@ def test_parse_with_extra_lines(self):
     def test_parse_with_unknown_fields(self):
         content = """sentry-cli-version: 2.58.2
 unknown-field: some-value
-fastlane-plugin: 1.2.3"""
+sentry-fastlane-plugin: 1.2.3"""
         metadata = _parse_metadata_content(content)
         assert metadata.cli_version == "2.58.2"
         assert metadata.fastlane_plugin_version == "1.2.3"
@@ -87,7 +87,7 @@ def test_extract_from_zip_root(self):
                 with zipfile.ZipFile(tf.name, "w") as zf:
                     zf.writestr(
                         ".sentry-cli-metadata.txt",
-                        "sentry-cli-version: 2.58.2\nfastlane-plugin: 1.2.3\ngradle-plugin: 4.12.0",
+                        "sentry-cli-version: 2.58.2\nsentry-fastlane-plugin: 1.2.3\nsentry-gradle-plugin: 4.12.0",
                     )
                     zf.writestr("some-file.txt", "content")