Skip to content

Commit 0cfd711

Browse files
runningcodeclaude
andcommitted
refactor: Update metadata keys to use -version suffix (EME-606)
Updates the metadata file keys to be more explicit: - fastlane-plugin -> fastlane-plugin-version - gradle-plugin -> gradle-plugin-version This makes the key names more descriptive and consistent. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 4b10d48 commit 0cfd711

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/launchpad/artifact_processor.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -418,13 +418,13 @@ def _extract_tooling_versions(self, artifact: Artifact) -> Dict[str, str | None]
418418
and extracts version information.
419419
420420
Returns:
421-
Dict with keys: sentry_cli_version, fastlane_version, gradle_plugin_version
421+
Dict with keys: sentry_cli_version, fastlane_plugin_version, gradle_plugin_version
422422
"""
423423
import zipfile
424424

425425
versions = {
426426
"sentry_cli_version": None,
427-
"fastlane_version": None,
427+
"fastlane_plugin_version": None,
428428
"gradle_plugin_version": None,
429429
}
430430

src/launchpad/utils/metadata_extractor.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,8 @@ def _parse_metadata_content(content: str) -> ToolingMetadata:
6565
6666
Expected format:
6767
sentry-cli-version: 2.58.2
68-
fastlane-plugin: 1.2.3
69-
gradle-plugin: 4.12.0
68+
fastlane-plugin-version: 1.2.3
69+
gradle-plugin-version: 4.12.0
7070
7171
Args:
7272
content: The text content of the metadata file
@@ -89,6 +89,6 @@ def _parse_metadata_content(content: str) -> ToolingMetadata:
8989

9090
return ToolingMetadata(
9191
cli_version=metadata.get("sentry-cli-version"),
92-
fastlane_plugin_version=metadata.get("fastlane-plugin"),
93-
gradle_plugin_version=metadata.get("gradle-plugin"),
92+
fastlane_plugin_version=metadata.get("fastlane-plugin-version"),
93+
gradle_plugin_version=metadata.get("gradle-plugin-version"),
9494
)

tests/unit/artifacts/test_artifact_processor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ def test_extract_tooling_versions_with_sentry_cli_version(self, tmp_path):
321321

322322
# Verify sentry-cli version was extracted
323323
assert versions["sentry_cli_version"] == "2.39.1"
324-
assert versions["fastlane_version"] is None
324+
assert versions["fastlane_plugin_version"] is None
325325
assert versions["gradle_plugin_version"] is None
326326

327327
def test_extract_tooling_versions_no_metadata_file(self, tmp_path):

0 commit comments

Comments
 (0)