Refactor to use patches and add Secrets Manager template #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor prepare_source.sh to use patch files instead of sed - Add patches/ directory with 5 patch files for clean modifications - Add auth.py patch for graceful API key fallback - Add Secrets Manager template option (template-with-secrets-manager.yaml) - Update GitHub Actions workflow to set API_KEY env var for tests - Update README with patches info and Secrets Manager deployment option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
prepare_source.shto use patch files instead of sed for cleaner, maintainable code modificationspatches/directory:auth.py.patch- Graceful API key fallback (fixes local testing)app.py.patch- Remove Mangum importrequirements.txt.patch- Remove mangum dependencypydantic-version.patch- Update pydantic version constraintno-embeddings.patch- Remove embeddings (applied conditionally)template-with-secrets-manager.yamlfor optional Secrets Manager deployment (~$0.40/month)API_KEYenv var for local uvicorn testsTesting
All 4 deployments tested successfully:
CI will validate the build process.