-
Notifications
You must be signed in to change notification settings - Fork 38
Remove vcf annotator healthcheck #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jsstevenson would you please review this. the think-tank group decided the healthcheck() was not necessary so we removed it. If you have a counter arg, please make it, otherwise we will move forward. |
|
I'd be fine with removal for now. The bigger problem is that the VCF annotator suppresses all exceptions and just dumps them verbatim onto the VCF in an |
|
After discussion we decided that at least the filesystem and the REST based dataproxies should work the same way, in that they will fail at construction time if the underlying data source is not accessible. This latest commit adds a call to the |
cb4f975 to
499f173
Compare
|
I have no idea why the tests are failing because they run locally with I do |
|
I think the problem is the |
… one test to add vcr. Re-record cassettes.
Close #530