Adaptation to breaking FCS changes in sdk 9.0 and 10.0 #3167
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "10.0.100", | ||
| "rollForward": "latestPatch" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #r "../artifacts/bin/Fantomas.FCS/debug/Fantomas.FCS.dll" | ||
|
|
||
| open System.IO | ||
|
|
||
| match Array.tryHead fsi.CommandLineArgs with | ||
|
Contributor
There was a problem hiding this comment. Useful to test out the local compiler and view changes that Fantomas Tools might not yet have. |
||
| | Some scriptPath -> | ||
| let scriptFile = FileInfo(scriptPath) | ||
| let sourceFile = FileInfo(Path.Combine(__SOURCE_DIRECTORY__, __SOURCE_FILE__)) | ||
|
|
||
| if scriptFile.FullName = sourceFile.FullName then | ||
| let sample = File.ReadAllText(fsi.CommandLineArgs.[fsi.CommandLineArgs.Length - 1]) | ||
| let isSignature = sample.EndsWith(".fsi") | ||
nojaf marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| let ast = | ||
| Fantomas.FCS.Parse.parseFile isSignature (Fantomas.FCS.Text.SourceText.ofString sample) [] | ||
| |> fst | ||
|
|
||
| ast |> printfn "%A" | ||
| | _ -> printfn "Usage: dotnet fsi ast.fsx <input file>" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #r "../artifacts/bin/Fantomas.FCS/debug/Fantomas.FCS.dll" | ||
| #r "../artifacts/bin/Fantomas.Core/debug/Fantomas.Core.dll" | ||
|
|
||
| open System.Threading.Tasks | ||
| open Fantomas.Core | ||
|
|
||
| let parseOak (input: string) (isSignature: bool) : Task<string> = | ||
| task { | ||
| try | ||
| let! oaks = CodeFormatter.ParseOakAsync(isSignature, input) | ||
|
|
||
| match Array.tryHead oaks with | ||
| | None -> return "No Oak found in input" | ||
| | Some(oak, _) -> return (string oak) | ||
|
|
||
| with ex -> | ||
| return $"Error while parsing to Oak: %A{ex}" | ||
| } | ||
|
|
||
| open System.IO | ||
|
|
||
| match Array.tryHead fsi.CommandLineArgs with | ||
| | Some scriptPath -> | ||
| let scriptFile = FileInfo(scriptPath) | ||
| let sourceFile = FileInfo(Path.Combine(__SOURCE_DIRECTORY__, __SOURCE_FILE__)) | ||
|
|
||
| if scriptFile.FullName = sourceFile.FullName then | ||
| let sample = File.ReadAllText(fsi.CommandLineArgs.[fsi.CommandLineArgs.Length - 1]) | ||
| let isSignature = sample.EndsWith(".fsi") | ||
nojaf marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| parseOak sample isSignature | ||
| |> Async.AwaitTask | ||
| |> Async.RunSynchronously | ||
| |> printfn "%s" | ||
| | _ -> printfn "Usage: dotnet fsi oak.fsx <input file>" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I no longer remember how this stuff works, but can we stick to dotnet 8 SDK and versions? Or do you really need 9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the new nullness-related constructs, compiling the current compiler service requires 9.0 or higher for both fsc and FSharp.Core.
That's why I wrote above that this PR might be a draft one for quite some time.
I am assuming you might want to wait for the LTS SDK 10.
Regarding features I don't think there is a big pressure to move. The current Fantomas can deal with sources that contain nullness constructs or #warnon.
It is just that the changes accumulate. I naively just wanted to make the changes for "scoped nowarn" but found I had to deal with three other breaking changes also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any more details on that? What exactly in FSharp.Core 9 does any of this depend on?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is all about nullness.
If I compile with SDK 9.0.300 and FSharp.Core 8.0.100, I get 85 errors in the Fantomas.FCS project, mostly about unknown
objnullandNonNull.