Skip to content

Fix ValueTask.ignore based on Stephen Toub's insights #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Fix ValueTask.ignore based on Stephen Toub's insights #113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/FSharp.Control.TaskSeq/Utils.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,11 @@ module ValueTask =

/// Ignore a ValueTask<'T>, returns a non-generic ValueTask.
let inline ignore (vtask: ValueTask<'T>) =
if vtask.IsCompleted then
// this implementation follows Stephen Toub's advice, see:
// https://github.com/dotnet/runtime/issues/31503#issuecomment-554415966
if vtask.IsCompletedSuccessfully then
// ensure any side effect executes
vtask.Result |> ignore
ValueTask()
else
ValueTask(vtask.AsTask())
Expand Down Expand Up @@ -63,6 +67,7 @@ module Task =
/// Convert a Task<'T> into a non-generic Task, ignoring the result
let inline ignore (task: Task<'T>) =
TaskBuilder.task {
// ensure the task is awaited
let! _ = task
return ()
}
Expand Down