Add no-GIL support #267
Add no-GIL support #267
Conversation
| endif | ||
|
|
||
| extension = python.extension_module('_frida', 'extension.c', | ||
| limited_api: '3.7', |
There was a problem hiding this comment.
This seems like a regression, unless I'm missing something?
There was a problem hiding this comment.
Now that you ask, maybe that is no longer needed?
There was a problem hiding this comment.
The reason we have it is so we can build a single binary (per OS/ABI combo) that works on older Python runtimes even when the build machine has a newer Python; without accidentally regressing on the range of versions supported.
There was a problem hiding this comment.
The reason we have it is so we can build a single binary (per OS/ABI combo) that works on older Python runtimes even when the build machine has a newer Python; without accidentally regressing on the range of versions supported.
Just to be sure, can you run workflows on your side to catch whatever regression that may arise from this PR?
There was a problem hiding this comment.
There's no point; I went through some pain to transition frida-python to the limited API, because it solved some long-standing issues. Nothing changed there. We cannot drop this.
There was a problem hiding this comment.
Fair enough: https://peps.python.org/pep-0803/ means that free-threaded wheels will have stable ABI starting in 3.15...
Co-authored-by: Ole André Vadla Ravnås <oleavr@gmail.com>
| endif | ||
|
|
||
| extension = python.extension_module('_frida', 'extension.c', | ||
| limited_api: '3.7', |
There was a problem hiding this comment.
There's no point; I went through some pain to transition frida-python to the limited API, because it solved some long-standing issues. Nothing changed there. We cannot drop this.
Hopefully with https://peps.python.org/pep-0803/, no-GIL wheels will be stable (and meson supports this as well)
2 participants
No description provided.