-
Notifications
You must be signed in to change notification settings - Fork 0
chore/security #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flyingrobots
wants to merge
4
commits into
main
Choose a base branch
from
chore/security
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,175
−11
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
25cb2bb
review: paginate seeding; add comments dumper; update security policy
flyingrobots f5312b4
opus(PR#3): seed rehearsal score (25cb2bb4b000cad26fd5fcc02cb51867758…
f775e24
Apply suggestions from code review
flyingrobots 6bc8aa2
opus(PR#3): seed rehearsal score (f775e24c1d3578c42f823710cd23295d4d9…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
docs/code-reviews/PR3/25cb2bb4b000cad26fd5fcc02cb5186775827c40.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| --- | ||
| title: 25cb2bb4b000cad26fd5fcc02cb5186775827c40.md | ||
| description: Preserved review artifacts and rationale. | ||
| audience: [contributors] | ||
| domain: [quality] | ||
| tags: [review] | ||
| status: archive | ||
| --- | ||
|
|
||
| # Code Review Feedback | ||
|
|
||
| | Date | Agent | SHA | Branch | PR | | ||
| |------|-------|-----|--------|----| | ||
| | 2025-11-06 | CodeRabbit (and reviewers) | `25cb2bb4b000cad26fd5fcc02cb5186775827c40` | [chore/security](https://github.com/flyingrobots/draft-punks/tree/chore/security "flyingrobots/draft-punks:chore/security") | [PR#3](https://github.com/flyingrobots/draft-punks/pull/3) | | ||
|
|
||
| ## CODE REVIEW FEEDBACK | ||
|
|
||
| ### General comment — coderabbitai[bot] | ||
|
|
||
| ```text | ||
| <!-- This is an auto-generated comment: summarize by coderabbit.ai --> | ||
| <!-- This is an auto-generated comment: review in progress by coderabbit.ai --> | ||
|
|
||
| > [!NOTE] | ||
| > Currently processing new changes in this PR. This may take a few minutes, please wait... | ||
| > | ||
| > <details> | ||
| > <summary>📥 Commits</summary> | ||
| > | ||
| > Reviewing files that changed from the base of the PR and between 34ec9acc1dab75b82c6065490e1976eb338ae304 and 25cb2bb4b000cad26fd5fcc02cb5186775827c40. | ||
| > | ||
| > </details> | ||
| > | ||
| > <details> | ||
| > <summary>⛔ Files ignored due to path filters (1)</summary> | ||
| > | ||
| > * `SECURITY.md` is excluded by `!*.md` | ||
| > | ||
| > </details> | ||
| > | ||
| > <details> | ||
| > <summary>📒 Files selected for processing (2)</summary> | ||
| > | ||
| > * `tools/review/get_comments_markdown.py` (1 hunks) | ||
| > * `tools/review/seed_feedback_from_github.py` (2 hunks) | ||
| > | ||
| > </details> | ||
| > | ||
| > ```ascii | ||
| > ____________________________________ | ||
| > < Zero-day? Zero chance on my watch. > | ||
| > ------------------------------------ | ||
| > \ | ||
| > \ \ | ||
| > \ /\ | ||
| > ( ) | ||
| > .( o ). | ||
| > ``` | ||
|
|
||
| <!-- end of auto-generated comment: review in progress by coderabbit.ai --> | ||
| <!-- usage_tips_start --> | ||
|
|
||
| > [!TIP] | ||
| > <details> | ||
| > <summary>CodeRabbit can generate a title for your PR based on the changes with custom instructions.</summary> | ||
| > | ||
| > Add the `reviews.auto_title_instructions` setting in your project's settings in CodeRabbit to generate a title for your PR based on the changes in the PR with custom instructions. | ||
| > | ||
| > </details> | ||
|
|
||
| <!-- usage_tips_end --> | ||
|
|
||
| <!-- finishing_touch_checkbox_start --> | ||
|
|
||
| <details> | ||
| <summary>✨ Finishing touches</summary> | ||
|
|
||
| - [ ] <!-- {"checkboxId": "7962f53c-55bc-4827-bfbf-6a18da830691"} --> 📝 Generate docstrings | ||
| <details> | ||
| <summary>🧪 Generate unit tests (beta)</summary> | ||
|
|
||
| - [ ] <!-- {"checkboxId": "f47ac10b-58cc-4372-a567-0e02b2c3d479", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Create PR with unit tests | ||
| - [ ] <!-- {"checkboxId": "07f1e7d6-8a8e-4e23-9900-8731c2c87f58", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Post copyable unit tests in a comment | ||
| - [ ] <!-- {"checkboxId": "6ba7b810-9dad-11d1-80b4-00c04fd430c8", "radioGroupId": "utg-output-choice-group-unknown_comment_id"} --> Commit unit tests in branch `chore/security` | ||
|
|
||
| </details> | ||
|
|
||
| </details> | ||
|
|
||
| <!-- finishing_touch_checkbox_end --> | ||
|
|
||
| <!-- tips_start --> | ||
|
|
||
| --- | ||
|
|
||
| Thanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=flyingrobots/draft-punks&utm_content=3)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. | ||
|
|
||
| <details> | ||
| <summary>❤️ Share</summary> | ||
|
|
||
| - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) | ||
| - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) | ||
| - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) | ||
| - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code) | ||
|
|
||
| </details> | ||
|
|
||
| <sub>Comment `@coderabbitai help` to get the list of available commands and usage tips.</sub> | ||
|
|
||
| <!-- tips_end --> | ||
| ``` | ||
|
|
||
| _Meta_: https://github.com/flyingrobots/draft-punks/pull/3#issuecomment-3495262753 | ||
|
|
||
| {response} | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.