Skip to content

Conversation

@LouiseHsu
Copy link
Contributor

@LouiseHsu LouiseHsu commented Dec 10, 2025

This pr adds some docs to support dynamic content resizing for add to app scenarios.

flutter/flutter#177410

This should land after Jan 14, since the feature landed on Dec 2, according to https://sites.google.com/corp/google.com/dash/operations-hub/releases

Presubmit checklist

  • If you are unwilling, or unable, to sign the CLA, even for a tiny, one-word PR, please file an issue instead of a PR.
  • If this PR is not meant to land until a future stable release, mark it as draft with an explanation.
  • This PR follows the Google Developer Documentation Style Guidelines—for example, it doesn't use i.e. or e.g., and it avoids I and we (first-person pronouns).
  • This PR uses semantic line breaks
    of 80 characters or fewer.

@LouiseHsu LouiseHsu requested review from a team and sfshaza2 as code owners December 10, 2025 23:40
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @LouiseHsu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the iOS 'add-to-app' documentation by providing comprehensive guidance on implementing dynamic content resizing for embedded Flutter views. It outlines the necessary steps to enable this feature, details the limitations concerning certain Flutter widgets, and offers practical code examples and a sample project to assist developers in integrating Flutter content that can adapt its size dynamically within an iOS application.

Highlights

  • New Documentation Section: A new section titled 'Content Sized Views' has been added to the iOS 'add-to-app' documentation.
  • Enabling Content Resizing: The documentation now includes instructions and code examples (in Swift and Objective-C) on how to enable isAutoResizable for FlutterViewController to allow embedded Flutter views to size themselves based on their content.
  • Restrictions and Unsupported Widgets: Detailed information has been added regarding the restrictions of content-sized Flutter views, specifically highlighting that widgets with unbounded size (e.g., ListView) and those that defer to children for sizing (e.g., LayoutBuilder) are not supported.
  • Widget Compatibility Testing: A Dart code example using UnconstrainedBox is provided to help developers test the usability of various Flutter widgets within a content-sized view context.
  • Sample Project Reference: A link to a sample project demonstrating content resizing for iOS 'add-to-app' scenarios has been included for practical reference.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 10, 2025

Visit the preview URL for this PR (updated for commit 12a618b):

https://flutter-docs-prod--pr12810-content-resizing-ha8g1duf.web.app

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR adds documentation for supporting content resizing on iOS in add-to-app scenarios. The changes are clear and provide useful code snippets for Swift, Objective-C, and Dart. I've made a few suggestions to improve grammar, ensure consistency between code examples, and adhere to the Google Developer Documentation Style Guide.

sfshaza2 and others added 5 commits December 12, 2025 16:50
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
gemini suggestion

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once some nits are addressed.

@sfshaza2
Copy link
Contributor

@LouiseHsu, can you add this to the index file? Then it can land.

Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing a couple typos in the URLs.

@sfshaza2
Copy link
Contributor

Land once the page is added to the index file.

@LouiseHsu LouiseHsu changed the title Add docs to support content resizing on iOS [Developer Draft] Add docs to support content resizing on iOS Dec 16, 2025
@LouiseHsu LouiseHsu marked this pull request as draft December 16, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants