-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[shared_preferences_tool] Update dependencies and fix deprecation #10560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[shared_preferences_tool] Update dependencies and fix deprecation #10560
Conversation
| @@ -1,5 +1,6 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates shared preferences devtools extension dependencies | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stuartmorgan-g should I actually update the version?
| }); | ||
| }); | ||
| </script> | ||
| <script src="flutter_bootstrap.js" async></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also updated this, which was also a deprecation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies for the shared_preferences_tool package, including devtools_app_shared, devtools_extensions, build_runner, and mockito. It also updates the Dart SDK constraint. As part of these updates, several deprecations are addressed: the requiresRunningApplication parameter is removed from DevToolsExtension widgets in tests, and the web app initialization in index.html is updated to use the modern flutter_bootstrap.js script. The changes are logical and correctly address the dependency updates and deprecations. I have one suggestion to make the changelog entry more descriptive.
| @@ -1,5 +1,6 @@ | |||
| ## NEXT | |||
|
|
|||
| * Updates shared preferences devtools extension dependencies | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better clarity, consider making this changelog entry more descriptive to fully capture the scope of the changes. The current description is a bit generic. A more detailed entry would better inform users about what was updated and fixed.
| * Updates shared preferences devtools extension dependencies | |
| * Updates dependencies for the `shared_preferences_tool` DevTools extension and fixes related deprecations. |
Update the dependencies and fix deprecations.
Issues:
flutter/flutter#166602
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3