Skip to content

Conversation

@adsonpleal
Copy link
Contributor

Update the dependencies and fix deprecations.

Issues:

flutter/flutter#166602

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@@ -1,5 +1,6 @@
## NEXT

* Updates shared preferences devtools extension dependencies
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartmorgan-g should I actually update the version?

});
});
</script>
<script src="flutter_bootstrap.js" async></script>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated this, which was also a deprecation.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies for the shared_preferences_tool package, including devtools_app_shared, devtools_extensions, build_runner, and mockito. It also updates the Dart SDK constraint. As part of these updates, several deprecations are addressed: the requiresRunningApplication parameter is removed from DevToolsExtension widgets in tests, and the web app initialization in index.html is updated to use the modern flutter_bootstrap.js script. The changes are logical and correctly address the dependency updates and deprecations. I have one suggestion to make the changelog entry more descriptive.

@@ -1,5 +1,6 @@
## NEXT

* Updates shared preferences devtools extension dependencies

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity, consider making this changelog entry more descriptive to fully capture the scope of the changes. The current description is a bit generic. A more detailed entry would better inform users about what was updated and fixed.

Suggested change
* Updates shared preferences devtools extension dependencies
* Updates dependencies for the `shared_preferences_tool` DevTools extension and fixes related deprecations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant