Feat/delete read notifications #218
Conversation
- Implement a new getter in InAppNotificationCenterState to check for read items in the current tab - This change will help optimize the notification center UI by allowing us to display read/unread status more effectively
- Add new event class `InAppNotificationCenterReadItemsDeleted` - This event is dispatched when user requests to delete all read items in the active tab
…center - Add event handler for deleting read notifications in the current tab - Implement optimistic UI update to remove read items immediately - Perform actual deletion in the background - Handle empty read notifications scenario - Log errors without reverting state to avoid UI flicker
…tons - Add mark all as read button with tooltip - Implement delete read notifications button with confirmation dialog - Update button availability based on current notification state
- Add Arabic and English translations for new strings related to deleting read notifications - Include tooltip, dialog content, and button label for the feature
- Adjust indentation and line breaks for better readability - Remove unnecessary BlocBuilder widget - Simplify AlertDialog content creation
…_bloc.dart - Adjust line breaks and indentation for better readability - Ensure consistent code style throughout the file
- Add new deleting state to InAppNotificationCenterStatus enum - Update InAppNotificationCenterState documentation
…n center UI - Add confirmation dialog before deleting read notifications - Implement delete in progress UI blocking - Improve app bar actions by disabling buttons when deleting - Refactor UI using BlocBuilder for better state management
- Optimize the deletion process by adding a loading state - Refetch the current tab's data after deletion to ensure consistency - Improve error handling and state management - Update UI immediately
- Replaced Container with ColoredBox in the in-app notification center page - This change improves performance by using a more efficient widget for colored backgrounds
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant new feature to the in-app notification center, allowing users to efficiently manage their notifications by deleting all read items in a given tab. This enhancement improves user experience by providing a clear mechanism for decluttering the notification list, backed by robust state management and a user-friendly confirmation flow. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a feature to delete read notifications. The implementation is well-structured, covering BLoC logic, state management, UI updates, and localization. My review focuses on improving performance, robustness, and code clarity within the BLoC. I've identified a critical null-safety issue, a high-severity performance concern with the deletion process, and a medium-severity opportunity to refactor state emissions for better clarity.
github-project-automation
bot
moved this from Backlog
to Done
in Flutter News App Project
Status
READY
Description
This pull request introduces a significant new feature to the in-app notification center, allowing users to efficiently manage their notifications by deleting all read items in a given tab. This enhancement improves user experience by providing a clear mechanism for decluttering the notification list, backed by robust state management and a user-friendly confirmation flow.
Type of Change