-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor/improve logging #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2d0e462
feat: add global logging configuration
fulleni d213969
refactor(router): replace prints with logger in router configuration
fulleni 7841e40
feat(app): instantiate and provide logger to router
fulleni e1103f2
chore(router): improve log messages in go_router_observer
fulleni 880c64d
style(bootstrap): update Logger root listener syntax
fulleni 6bfec18
fix(router): integrate go_router_observer into router configuration
fulleni 06ffd3b
feat(bootstrap): add robust logging to bootstrap process
fulleni dd2ef00
refactor(logger): improve log message formatting and structure
fulleni 48b1da6
refactor(bootstrap): improve logger usage and code readability
fulleni 6047377
fix(router): resolve import path issue and update observer registration
fulleni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import 'package:flutter/material.dart'; | ||
| import 'package:logging/logging.dart'; | ||
|
|
||
| class GoRouterObserver extends NavigatorObserver { | ||
fulleni marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| GoRouterObserver({required this.logger}); | ||
|
|
||
| final Logger logger; | ||
|
|
||
| @override | ||
| void didPush(Route<dynamic> route, Route<dynamic>? previousRoute) { | ||
| logger.info( | ||
| 'Pushed: ${route.settings.name} | from: ${previousRoute?.settings.name}', | ||
| ); | ||
| } | ||
|
|
||
| @override | ||
| void didPop(Route<dynamic> route, Route<dynamic>? previousRoute) { | ||
| logger.info( | ||
| 'Popped: ${route.settings.name} | to: ${previousRoute?.settings.name}', | ||
| ); | ||
| } | ||
|
|
||
| @override | ||
| void didRemove(Route<dynamic> route, Route<dynamic>? previousRoute) { | ||
| logger.info( | ||
| 'Removed: ${route.settings.name} | previous: ${previousRoute?.settings.name}', | ||
| ); | ||
| } | ||
|
|
||
| @override | ||
| void didReplace({Route<dynamic>? newRoute, Route<dynamic>? oldRoute}) { | ||
| logger.info( | ||
| 'Replaced: ${oldRoute?.settings.name} | with: ${newRoute?.settings.name}', | ||
| ); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.