Refactor simplify feed items #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed duplicate export
- Removed duplicated tests - Simplified FeedItem tests
- Updated from feedback to rateApp
- Removed suggested content - Moved enum to related file
- Removed unused remote config rules - Cleaned up app config model
- Removed unused files - Deleted related tests
- Moved enum declaration - To improve code readability
- Renamed UserPreferenceLimits - to UserPreferenceConfig - Updated usages
- Replaced UserPreferenceLimits - Added UserPreferenceConfig model - Defines user preference limits
- Removed UserPreferenceLimits model - Removed associated tests - Removed SuggestedContentDisplayType tests
- Fix AppConfig _$AppConfigFromJson - Use UserPreferenceConfig model
- Renamed ad_placement file - Updated imports in tests
- Renamed for clarity - Updated tests accordingly - Updated README.md
- Clarified feed item content types - Updated user & app config descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY/IN DEVELOPMENT/HOLD
Description
Type of Change