fix(PLAY-1179): send usage analytics only when media_id is loaded #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximzavadskiy
force-pushed
the
fix/PLAY-1179/usage_analytics_correction
branch
2 times, most recently
from
f46bbc6 to
b720c00
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes analytics tracking to only send usage events when a media_id is loaded, preventing analytics events from being sent for media without proper identifiers.
- Adds a check to ensure media_id or stream_target_id exists before sending analytics
- Implements event listener on SOURCE event to track when media is loaded
- Adds once-only tracking to prevent duplicate analytics events
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
maximzavadskiy
force-pushed
the
fix/PLAY-1179/usage_analytics_correction
branch
from
1176664 to
b122ada
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(PLAY-1179): send usage analytics only when
media_idis loaded