coreos-base/coreos-init: add EGIT_BRANCH
#3604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are using the git eclass, we can't simply use a git ref if this one is on another branch, we need to pass the git branch as well. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
requested a deployment
to
development
GitHub Actions
Waiting
tormath1
changed the title
EGIT_BRANCH
pothos
approved these changes
Dec 23, 2025
Member
pothos
left a comment
pothos
left a comment
There was a problem hiding this comment.
Thanks, I thought this was redundant because with the previous git ref mechanism this wasn't needed.
Contributor
|
The previous mechanism fetched all the branches, which wasn't very efficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are using the git eclass, we can't simply use a git ref if this one is on another branch, we need to pass the git branch as well.
(Stable variant of #3603 - this one can't be cherry-picked as initially 'flatcar-4459' was not using the
backportvariant)